feat: hardhat task to test chain adapter token bridging #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has some limitations around USDC native/bridged coincidence, but should otherwise be useful for testing chain adapters for new deployments (where CCTP is very unlikely to be enabled anyway).
pxrl
commented
Oct 16, 2024
pxrl
commented
Oct 16, 2024
pxrl
commented
Oct 16, 2024
|
|
||
| task("testChainAdapter", "Verify a chain adapter") | ||
| .addParam("chain", "chain ID of the adapter being tested") | ||
| .addParam("token", "Token to bridge to the destination chain") |
There was a problem hiding this comment.
Should probably addParam("amount", ...) here to allow the user to specify the amount to bridge.
pxrl
commented
Oct 16, 2024
tasks/testChainAdapter.ts
Outdated
|
|
||
| const erc20 = (await ethers.getContractFactory("ExpandedERC20")).attach(tokenAddress); | ||
| const amount = 1_000_000; | ||
| let txn = await erc20.connect(signer).transfer(adapterAddress, amount); |
There was a problem hiding this comment.
It's probably worth adding a warning here, since this transfer can be rugged by any third party who happens to call relayTokens first.
bmzig
approved these changes
Oct 17, 2024
bmzig
approved these changes
Oct 25, 2024
pxrl
added a commit
that referenced
this pull request
Oct 28, 2024
This has some limitations around USDC native/bridged coincidence, but should otherwise be useful for testing chain adapters for new deployments (where CCTP is very unlikely to be enabled anyway).
pxrl
added a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has some limitations around USDC native/bridged coincidence, but should otherwise be useful for testing chain adapters for new deployments (where CCTP is very unlikely to be enabled anyway).