improve(Arbitrum_CustomGasToken_Adapter): Handle non-18 custom gas token precision #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ken precision Based on this [Inbox](https://github.com/OffchainLabs/nitro-contracts/blob/fbbcef09c95f69decabaced3da683f987902f3e2/src/bridge/AbsInbox.sol#L237) code which implies that the `tokenTotalFeeAmount` passed into the [ERC20Inbox](https://github.com/OffchainLabs/nitro-contracts/blob/fbbcef09c95f69decabaced3da683f987902f3e2/src/bridge/ERC20Inbox.sol#L85) should be in the custom gas token's precision while the `maxSubmissionCost`, `gasPrice`, and `gasLimit` should all be same as for normal Arbitrum messages
nicholaspai
commented
Sep 3, 2024
nicholaspai
commented
Sep 3, 2024
nicholaspai
commented
Sep 4, 2024
| * @return amount of gas token that this contract needs to hold in order for relayMessage to succeed. | ||
| */ | ||
| function getL1CallValue(uint32 l2GasLimit) public view returns (uint256) { | ||
| return L2_MAX_SUBMISSION_COST + L2_GAS_PRICE * l2GasLimit; | ||
| return _from18ToNativeDecimals(L2_MAX_SUBMISSION_COST + L2_GAS_PRICE * l2GasLimit); |
There was a problem hiding this comment.
the benefit of putting the scaling logic into this public function is the deployer can quickly sanity check post-deployment that the L1CallValue will be set correctly with the right precision
mrice32
approved these changes
Sep 9, 2024
I believe the L2 native token is hardcoded to be 18 based on the [Inbox](https://github.com/OffchainLabs/nitro-contracts/blob/fbbcef09c95f69decabaced3da683f987902f3e2/src/bridge/AbsInbox.sol#L237] and ERC20Inbox code |
bmzig
approved these changes
Sep 11, 2024
pxrl
pushed a commit
that referenced
this pull request
Oct 8, 2024
…ken precision (#589) * improve(Arbitrum_CustomGasToken_Adapter): Handle non-18 custom gas token precision Based on this [Inbox](https://github.com/OffchainLabs/nitro-contracts/blob/fbbcef09c95f69decabaced3da683f987902f3e2/src/bridge/AbsInbox.sol#L237) code which implies that the `tokenTotalFeeAmount` passed into the [ERC20Inbox](https://github.com/OffchainLabs/nitro-contracts/blob/fbbcef09c95f69decabaced3da683f987902f3e2/src/bridge/ERC20Inbox.sol#L85) should be in the custom gas token's precision while the `maxSubmissionCost`, `gasPrice`, and `gasLimit` should all be same as for normal Arbitrum messages * Update contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol * Update contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol * Update Arbitrum_CustomGasToken_Adapter.sol * support deecimals > 18 * divCeil instead of divFLoor
nicholaspai
added a commit
that referenced
this pull request
Nov 6, 2024
* improve(Arbitrum_CustomGasToken_Adapter): Handle non-18 custom gas token precision (#589) * improve(Arbitrum_CustomGasToken_Adapter): Handle non-18 custom gas token precision Based on this [Inbox](https://github.com/OffchainLabs/nitro-contracts/blob/fbbcef09c95f69decabaced3da683f987902f3e2/src/bridge/AbsInbox.sol#L237) code which implies that the `tokenTotalFeeAmount` passed into the [ERC20Inbox](https://github.com/OffchainLabs/nitro-contracts/blob/fbbcef09c95f69decabaced3da683f987902f3e2/src/bridge/ERC20Inbox.sol#L85) should be in the custom gas token's precision while the `maxSubmissionCost`, `gasPrice`, and `gasLimit` should all be same as for normal Arbitrum messages * Update contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol * Update contracts/chain-adapters/Arbitrum_CustomGasToken_Adapter.sol * Update Arbitrum_CustomGasToken_Adapter.sol * support deecimals > 18 * divCeil instead of divFLoor * feat: WorldChain deployments (#634) * fix: Support OP bridged USDC in WorldChain adapter (#646) World Chain implements Circle's bridged USDC standard. Deposits & withdrawals cannot be initiated via the L1StandardBridge and L2StandardBridge contracts respectively. Instead they must be sent to World Chain's own implementations of Circle's bridged USDC standard. In recognition of the fact that this will likely be a repeating pattern for new deployments, restyle the World Chain adapter as a generic OP adapter and instead rely on deployment scripts to configure it with the correct bridges. Circle's standard is described here: https://github.com/circlefin/stablecoin-evm/blob/master/doc/bridged_USDC_standard.md The process for bridged USDC deposits & withdrawals is here: https://github.com/defi-wonderland/opUSDC/tree/main?tab=readme-ov-file#l1--l2-usdc-canonical-bridging * fix: Use custom USDC bridge in WorldChain_SpokePool (#647) * fix: Support OP bridged USDC in WorldChain adapter Signed-off-by: bennett <[email protected]> --------- Signed-off-by: bennett <[email protected]> Co-authored-by: Paul <[email protected]> * chore: Add WorldChain adapter deployment (#658) These are recorded under the OP adapter due to the name of the contract that was deployed. Some or all of this will be overwritten on subsequent OP adapter deployments. * chore: update World Chain deployment info with new implementation (#659) This is the deployment info for the WorldChain_SpokePool deployed at the current audit-latest code. Signed-off-by: bennett <[email protected]> * fix: modify Arbitrum_CustomGasToken_Adapter for Aleph Zero Signed-off-by: bennett <[email protected]> * split gas token adapters Signed-off-by: bennett <[email protected]> * remove native token decimals variable Signed-off-by: bennett <[email protected]> * make sure files are as similar as possible Signed-off-by: bennett <[email protected]> * import interfaces from base Signed-off-by: bennett <[email protected]> * inherit Signed-off-by: bennett <[email protected]> * collapse adapters Signed-off-by: bennett <[email protected]> * remove virtual Signed-off-by: bennett <[email protected]> * fix comment Signed-off-by: bennett <[email protected]> * go back to 18 decimals Signed-off-by: bennett <[email protected]> * remove Signed-off-by: bennett <[email protected]> * fix * add docstrings, decimal error, and scale l2CallValue Signed-off-by: bennett <[email protected]> * fix comment Signed-off-by: bennett <[email protected]> * add comment about rounding Signed-off-by: bennett <[email protected]> --------- Signed-off-by: bennett <[email protected]> Co-authored-by: nicholaspai <[email protected]> Co-authored-by: Paul <[email protected]> Co-authored-by: nicholaspai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this Inbox code which implies that the
tokenTotalFeeAmountpassed into the ERC20Inbox should be in the custom gas token's precision while themaxSubmissionCost,gasPrice, andgasLimitshould all be same as for normal Arbitrum messages