feat: redeploy spoke pools to support depositExclusive #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bennett <[email protected]>
james-a-morris
approved these changes
Aug 26, 2024
nicholaspai
reviewed
Aug 26, 2024
| @@ -132,7 +136,7 @@ const config: HardhatUserConfig = { | |||
| }, | |||
| arbitrum: { | |||
| chainId: CHAIN_IDs.ARBITRUM, | |||
| url: getNodeUrl("arbitrum", true, CHAIN_IDs.ARBITRUM), | |||
| url: getNodeUrl("arbitrum-mainnet", true, CHAIN_IDs.ARBITRUM), | |||
There was a problem hiding this comment.
these were renamed by infura?
There was a problem hiding this comment.
Yeah they must have been. They now follow a naming convention given by [network_name]-[mainnet or sepolia].infura.io.
There was a problem hiding this comment.
huh ok that makes sense, does this just not work currently with the renamed network names?
nicholaspai
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redeploys all spoke pools which were deployed before Lisk to support
depositExclusive. A nice byproduct is that now all chains also support tryMulticall.