refactor: Deployment script cleanup #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pxrl
commented
Jul 16, 2024
•
pxrl
commented
- Replace numeric chain IDs with symbolic IDs.
- Define constants for quote timestamp buffer and fill deadline buffer.
- Defer to upstream-defined token addresses.
- General minor refactoring to shrink code.
- Replace numeric chain IDs with symbolic IDs. - Defer to upstream-defined tokena addresses. - Remove pre-Sepolia testnet definitions.
Signed-off-by: Paul <[email protected]>
nicholaspai
approved these changes
Jul 24, 2024
pxrl
commented
Aug 9, 2024
Signed-off-by: Paul <[email protected]>
Signed-off-by: Paul <[email protected]>
Signed-off-by: Paul <[email protected]>
pxrl
commented
Aug 9, 2024
Signed-off-by: Paul <[email protected]>
bmzig
approved these changes
Aug 9, 2024
Signed-off-by: Paul <[email protected]>
Signed-off-by: Paul <[email protected]>
Signed-off-by: Paul <[email protected]>
pxrl
changed the title
Signed-off-by: Paul <[email protected]>
nicholaspai
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.