Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix usdb l2 bridge signature #554

Merged
merged 1 commit into from
Jul 13, 2024
Merged

fix: fix usdb l2 bridge signature #554

merged 1 commit into from
Jul 13, 2024

Conversation

mrice32
Copy link
Contributor

@mrice32 mrice32 commented Jul 13, 2024

USDB L2 -> L1 transfers are failing due to an incorrect function signature where the gas type was assumed to be uint256, as it is on other OP Stack chains, rather than uint32, which is what it is on Blast.

@@ -32,6 +32,17 @@ interface IBlast {
function claimMaxGas(address contractAddress, address recipientOfGas) external returns (uint256);
}

interface IUSDBL2Bridge {
Copy link
Contributor

@pxrl pxrl Jul 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For review, the Blast docs are here: https://docs.blast.io/building/contracts.
The relevant contract is the L2BlastBridge, here: https://blastscan.io/address/0x4300000000000000000000000000000000000005#writeProxyContract#F2

bridge

@mrice32 mrice32 merged commit 73844b1 into master Jul 13, 2024
11 checks passed
@mrice32 mrice32 deleted the blast_fix branch July 13, 2024 03:12
nicholaspai added a commit that referenced this pull request Jul 13, 2024
mrice32 added a commit that referenced this pull request Jul 17, 2024
nicholaspai added a commit that referenced this pull request Jul 24, 2024
* feat: Upgrade Blast_SpokePool implementation

New deployment following #554

* update script

Signed-off-by: nicholaspai <[email protected]>

---------

Signed-off-by: nicholaspai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants