improve(forge-ci): Ignore astId and other non-storage slot related props when diffing storage layouts #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ops when diffing storage layouts Remove props like astID and anything in types that are not minimally neccessary to compare storage layouts. Namely, we care about which slots state variables are using, which are ultimately downstream of `types` and independent of the AST layout
bmzig
approved these changes
Jun 17, 2024
james-a-morris
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove props like astID and anything in types that are not minimally neccessary to compare storage layouts.
Namely, we care about which slots state variables are using, which are ultimately downstream of
typesand independent of the AST layout