Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ERC7683Permit2Lib): Comply with EIP712 #519

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix(ERC7683Permit2Lib): Comply with EIP712 #519

merged 3 commits into from
Jun 17, 2024

Conversation

nicholaspai
Copy link
Member

  • should use abi.encode instead of abi.encodePacked when encoding data into a hash
  • Should keccak256 any bytes member like message in the AcrossOrderData struct

@nicholaspai
fix(ERC7683Permit2Lib): Comply with EIP712
36143df 
- should use abi.encode instead of abi.encodePacked when encoding data into a hash
- Should keccak256 any `bytes` member like `message` in the `AcrossOrderData` struct
@nicholaspai
Update ERC7683Across.sol
37c6142
@nicholaspai nicholaspai requested review from mrice32, bmzig and pxrl June 14, 2024 18:04
@nicholaspai nicholaspai mentioned this pull request Jun 17, 2024
Merged
@nicholaspai nicholaspai merged commit 8b5bfc0 into master Jun 17, 2024
7 checks passed
@nicholaspai nicholaspai deleted the 0624oz/l02 branch June 17, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmzig bmzig bmzig approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@pxrl pxrl Awaiting requested review from pxrl pxrl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholaspai @bmzig