Add clause about not knowing minOutput.recipient at order creation time
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time Its not always known who the recipient of a `minOutput` will be, especially when creating an `OnchainCrossChainOrder` where the user submits their own order and the `originData` does not contain any reference to an exclusive relayer. Moreover, even in a `GaslessCrossChainOrder`, the filler creating the deposit on the origin chain might not always fill their own order on the destination chain if they do not set themselves as an exclusive relayer. Not all settlement contracts will allow an order to specify an exclusivity clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Its not always known who the recipient of a
minOutputwill be, especially when creating anOnchainCrossChainOrderwhere the user submits their own order and theoriginDatadoes not contain any reference to an exclusive relayer.Moreover, even in a
GaslessCrossChainOrder, the filler creating the deposit on the origin chain might not always fill their own order on the destination chain if they do not set themselves as an exclusive relayer.Not all settlement contracts will allow an order to specify an exclusivity clause.
Solution
Explicitly state setting
recipient: address(0)as an option when creating theminOutputs.