-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #63 to enable Drupal 10 support #64
Conversation
@TravisCarden the question is, do we want to do d10 only or try to support 8/9 in this? |
@mikemadison13 we only need to support Drupal 10 in the new branch. We cut a new major version whenever there's a breaking API change in Drupal core, which means major versions like 9 to 10. |
ok. then, i guess the question is what do we need to do to get this in? ORCA cannot pass until this is in, so this is "always" going to fail. |
Sure. Well, since this this 5.x branch doesn't support D9, we need to disable the D9 jobs, i.e., |
95634de
to
dfc72f8
Compare
@TravisCarden i'm still seeing the older version of the spec tool getting pulled in. any thoughts? |
.github/workflows/orca.yml
Outdated
- ISOLATED_TEST_ON_NEXT_MINOR # Isolated test on next minor Drupal core version. | ||
- INTEGRATED_TEST_ON_NEXT_MINOR # Integrated test on next minor Drupal core version. | ||
- ISOLATED_TEST_ON_NEXT_MINOR_DEV # Isolated test on next minor dev Drupal core version. | ||
- INTEGRATED_TEST_ON_NEXT_MINOR_DEV # Integrated test on next minor dev Drupal core version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need to be commented out, too, @mikemadison13, because they still resolve to Drupal 9.x. The *_TEST_ON_NEXT_MAJOR_LATEST_*
jobs down in jobs.build.strategy.matrix.orca-job
are the ones that matter right now (and they're already correct).
- ISOLATED_TEST_ON_NEXT_MINOR # Isolated test on next minor Drupal core version. | |
- INTEGRATED_TEST_ON_NEXT_MINOR # Integrated test on next minor Drupal core version. | |
- ISOLATED_TEST_ON_NEXT_MINOR_DEV # Isolated test on next minor dev Drupal core version. | |
- INTEGRATED_TEST_ON_NEXT_MINOR_DEV # Integrated test on next minor dev Drupal core version. | |
# - ISOLATED_TEST_ON_NEXT_MINOR # Isolated test on next minor Drupal core version. | |
# - INTEGRATED_TEST_ON_NEXT_MINOR # Integrated test on next minor Drupal core version. | |
# - ISOLATED_TEST_ON_NEXT_MINOR_DEV # Isolated test on next minor dev Drupal core version. | |
# - INTEGRATED_TEST_ON_NEXT_MINOR_DEV # Integrated test on next minor dev Drupal core version. |
Thanks, @mikemadison13! Merging. I'll follow up with a release promptly. |
Fixes #63.