Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #63 to enable Drupal 10 support #64

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

mikemadison13
Copy link
Contributor

@mikemadison13 mikemadison13 commented Nov 17, 2022

Fixes #63.

@mikemadison13
Copy link
Contributor Author

@TravisCarden the question is, do we want to do d10 only or try to support 8/9 in this?

@TravisCarden
Copy link
Contributor

@mikemadison13 we only need to support Drupal 10 in the new branch. We cut a new major version whenever there's a breaking API change in Drupal core, which means major versions like 9 to 10.

@mikemadison13
Copy link
Contributor Author

ok. then, i guess the question is what do we need to do to get this in? ORCA cannot pass until this is in, so this is "always" going to fail.

@TravisCarden
Copy link
Contributor

Sure. Well, since this this 5.x branch doesn't support D9, we need to disable the D9 jobs, i.e., *_TEST_ON_CURRENT*. (Of course, those jobs will become D10 soon, so we'll have to enable them again when they do.) Wanna comment them out and see what happens, @mikemadison13?

@mikemadison13 mikemadison13 force-pushed the 63 branch 2 times, most recently from 95634de to dfc72f8 Compare December 1, 2022 21:56
@mikemadison13
Copy link
Contributor Author

@TravisCarden i'm still seeing the older version of the spec tool getting pulled in. any thoughts?

Comment on lines 47 to 50
- ISOLATED_TEST_ON_NEXT_MINOR # Isolated test on next minor Drupal core version.
- INTEGRATED_TEST_ON_NEXT_MINOR # Integrated test on next minor Drupal core version.
- ISOLATED_TEST_ON_NEXT_MINOR_DEV # Isolated test on next minor dev Drupal core version.
- INTEGRATED_TEST_ON_NEXT_MINOR_DEV # Integrated test on next minor dev Drupal core version.
Copy link
Contributor

@TravisCarden TravisCarden Dec 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be commented out, too, @mikemadison13, because they still resolve to Drupal 9.x. The *_TEST_ON_NEXT_MAJOR_LATEST_* jobs down in jobs.build.strategy.matrix.orca-job are the ones that matter right now (and they're already correct).

Suggested change
- ISOLATED_TEST_ON_NEXT_MINOR # Isolated test on next minor Drupal core version.
- INTEGRATED_TEST_ON_NEXT_MINOR # Integrated test on next minor Drupal core version.
- ISOLATED_TEST_ON_NEXT_MINOR_DEV # Isolated test on next minor dev Drupal core version.
- INTEGRATED_TEST_ON_NEXT_MINOR_DEV # Integrated test on next minor dev Drupal core version.
# - ISOLATED_TEST_ON_NEXT_MINOR # Isolated test on next minor Drupal core version.
# - INTEGRATED_TEST_ON_NEXT_MINOR # Integrated test on next minor Drupal core version.
# - ISOLATED_TEST_ON_NEXT_MINOR_DEV # Isolated test on next minor dev Drupal core version.
# - INTEGRATED_TEST_ON_NEXT_MINOR_DEV # Integrated test on next minor dev Drupal core version.

@TravisCarden
Copy link
Contributor

Thanks, @mikemadison13! Merging. I'll follow up with a release promptly.

@TravisCarden TravisCarden changed the title Fixes #63 to enable D10 support. Enable D10 support Dec 8, 2022
@TravisCarden TravisCarden changed the title Enable D10 support Enable Drupal 10 support Dec 8, 2022
@TravisCarden TravisCarden merged commit c7ba433 into acquia:develop Dec 8, 2022
@TravisCarden TravisCarden changed the title Enable Drupal 10 support Fixes #63 to enable Drupal 10 support Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Drupal 10 support
2 participants