-
Notifications
You must be signed in to change notification settings - Fork 100
add acorn run --update/-u flag to update app if exists #710
Conversation
4851eee
to
b1f9832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first blush, this looks good to me. I'm going to get @ibuildthecloud's input on it
I really want this, but the approach should be different. "Run -u" and "update" should be slightly different from each other. Basically "acorn run -u" should be like k8s update and "acorn update" should be like k8s patch. update today will only change the fields you specify and not touch the other fields. Run -u should ensure all fields exactly match the arguments. So that means run -u will reset fields back to default values if the user didn't specify the flag. |
4f6e10e
to
a28e461
Compare
@iwilltry42 lets definitely try to get this one into v0.4.0. let me know when youve addressed @ibuildthecloud feedback. ill move the issue back to in progress |
9cb4391
to
5bad883
Compare
- triggers acorn update logic if app exists - does not work with --dev/-i - requires --name/-n to be specified Signed-off-by: Thorsten Klein <[email protected]>
Signed-off-by: Thorsten Klein <[email protected]>
b2e6076
to
6a15bf1
Compare
- new flags `acorn update --reset` and `acorn run --update` to trigger this behavior: undefined fields of an app updated with these flags will be reset to defaults Signed-off-by: Thorsten Klein <[email protected]>
6a15bf1
to
c0255e1
Compare
@ibuildthecloud does this come close to what you'd expect? |
Can you add this @iwilltry42 ? Moving this out to v0.4.1, which will basically be a milestone for this and one or two other issues that aren't quite ready. edit: was just flag that needed chagned |
Signed-off-by: Thorsten Klein <[email protected]>
cb97666
to
4756228
Compare
Ref #466
Notes
kubectl apply
, as that one does a 3-way patch merge, where it takes into account thelast-applied-configuration
annotation. This PR does not consider such annotations.