This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
add: translate registry unauthorized error when running a private image (#2101) #2102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2101
With this change,
ImageDetails
will translate HTTP StatusCodes returned by registries to equivalent Kubernetes API Errors that we can interpret client-side to e.g. tell the user to runacorn login
first before trying to run a private image.ImageDetails
is first in line to try to access the registry.Old Text
As you can see in the issue text, there is not much common text that we could match on and I hope we don't mask any "Unauthorized" errors coming from somewhere else (that I cannot think of right now). Here are some things that we **could** do:Checklist
This is a title (#1216)
. Here's an example