This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Use AppInstance type instead of App for get/list of Jobs #2076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to properly work with Manager, we should be using the
AppInstance
(internal) type forApps
. Since theJobs
is essentially a wrapper around theAppStatus.Jobs
section of anApp
's status this is essential to properly work in Manager.This also removes a section of code the client that is not needed and blocks the creation of the JobRestart sub resource in manager.
Checklist
This is a title (#1216)
. Here's an example