Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Use AppInstance type instead of App for get/list of Jobs #2076

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

tylerslaton
Copy link
Contributor

@tylerslaton tylerslaton commented Aug 16, 2023

In order to properly work with Manager, we should be using the AppInstance (internal) type for Apps. Since the Jobs is essentially a wrapper around the AppStatus.Jobs section of an App's status this is essential to properly work in Manager.

This also removes a section of code the client that is not needed and blocks the creation of the JobRestart sub resource in manager.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

The name/namespace from the JobRestart struct in the client it is not
needed and causes issues when integrating with Manager.

Signed-off-by: tylerslaton <[email protected]>
@tylerslaton tylerslaton merged commit 1bc1ea4 into acorn-io:main Aug 17, 2023
@tylerslaton tylerslaton deleted the use-internal-type branch August 17, 2023 14:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants