Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

acorn log works through deletion period (#1887) #1998

Merged
merged 2 commits into from
Aug 1, 2023
Merged

acorn log works through deletion period (#1887) #1998

merged 2 commits into from
Aug 1, 2023

Conversation

keyallis
Copy link
Contributor

@keyallis keyallis commented Jul 28, 2023 •
edited
Loading

#1887

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@keyallis keyallis changed the title acorn log works until deletion grace period ends (#1887) acorn log works through deletion grace period ends (#1887) Jul 29, 2023
@keyallis keyallis changed the title acorn log works through deletion grace period ends (#1887) acorn log works through deletion grace period (#1887) Jul 29, 2023
@keyallis keyallis marked this pull request as ready for review July 31, 2023 17:14
tylerslaton
tylerslaton reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@tylerslaton tylerslaton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me. How would you feel about adding an integration test for this here?

@keyallis keyallis changed the title acorn log works through deletion grace period (#1887) acorn log works through deletion period (#1887) Jul 31, 2023
thedadams
thedadams approved these changes Jul 31, 2023
View reviewed changes
@keyallis keyallis merged commit 7978551 into acorn-io:main Aug 1, 2023
@keyallis keyallis deleted the issue-1887 branch August 1, 2023 20:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tylerslaton tylerslaton tylerslaton left review comments

@thedadams thedadams thedadams approved these changes

@StrongMonkey StrongMonkey StrongMonkey approved these changes

@g-linville g-linville g-linville approved these changes

@njhale njhale Awaiting requested review from njhale

@iwilltry42 iwilltry42 Awaiting requested review from iwilltry42

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keyallis @thedadams @StrongMonkey @g-linville @tylerslaton