This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Fix openapi schema generation for event fields #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set formatting and extensions for the observed and details fields respectively. This prevents field manager from complaining when events are created. Signed-off-by: Nick Hale <[email protected]>
| @@ -10,7 +10,7 @@ func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenA | |||
| result := generated.GetOpenAPIDefinitions(ref) | |||
| for _, v := range result { | |||
| for name := range v.Schema.SchemaProps.Properties { | |||
| if name == "deployArgs" || name == "buildArgs" || name == "params" { | |||
| if name == "deployArgs" || name == "buildArgs" || name == "params" || name == "details" { | |||
There was a problem hiding this comment.
Oh, I forgot about this hack. This explains a lot of errors I see because this list is not comprehensive for all the places we use GenericMap. There's got to be a better more proper approach for this.
There was a problem hiding this comment.
I burned a lot of time trying to sniff out a better way to do this. I eventually stumbled onto https://github.com/kubernetes/kube-openapi/tree/master/pkg/generators#custom-openapi-type-definitions
... unfortunately, func (_ GenericMap) OpenAPIDefinition() openapi.OpenAPIDefinition {//... wasn't doing the trick (curiously enough, implementing the other two methods for MicroTime did though).
g-linville
approved these changes
Jul 21, 2023
tylerslaton
approved these changes
Jul 21, 2023
iwilltry42
approved these changes
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set formatting and extensions for the observed and details fields
respectively. This prevents field manager from complaining when events
are created.
Addresses #1672