This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Introduce a login retry when a user's token is expired #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
requested review from
njhale,
StrongMonkey,
iwilltry42,
g-linville and
tylerslaton
njhale
reviewed
Jul 20, 2023
pkg/manager/manager.go
Outdated
Comment on lines
143
to
150
| // reload config, could have changed | ||
| if newCfg, err := config.ReadCLIConfig(); err != nil { | ||
| return user, pass, err | ||
| } else { | ||
| *cfg = *newCfg | ||
| } | ||
| return user, pass, nil |
There was a problem hiding this comment.
Suggested change
| // reload config, could have changed | |
| if newCfg, err := config.ReadCLIConfig(); err != nil { | |
| return user, pass, err | |
| } else { | |
| *cfg = *newCfg | |
| } | |
| return user, pass, nil | |
| // reload config, could have changed | |
| newCfg, err := config.ReadCLIConfig() | |
| if err == nil { | |
| *cfg = *newCfg | |
| } | |
| return user, pass, err |
StrongMonkey
approved these changes
Jul 20, 2023
tylerslaton
approved these changes
Jul 20, 2023
g-linville
reviewed
Jul 21, 2023
njhale
approved these changes
Jul 21, 2023
Additionally, a user-agent string is added to requests to manager. Signed-off-by: Donnie Adams <[email protected]>
g-linville
approved these changes
Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, a user-agent string is added to requests to manager.