This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Change logserver to only print an error log if it fails #1944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The info log that was getting printed at the start of this caused several of our e2e tests to fail last night because they were not expecting that to be present in the output. There's very little that can go wrong while starting this thing anyway, so I think it makes more sense to just log and error if there is one, and otherwise be silent.
Checklist
This is a title (#1216)
. Here's an example