This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Enable filtering acorn events output to a given time span #1920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
force-pushed
the
events/filter-time
branch
from
f8ebd1d to
3632f1b
Compare
g-linville
reviewed
Jul 12, 2023
tylerslaton
approved these changes
Jul 13, 2023
Comment on lines
+67
to
+74
| func NewMicroTime(t time.Time) MicroTime { | ||
| return MicroTime(metav1.NewMicroTime(t)) | ||
| } | ||
|
|
||
| func NowMicro() MicroTime { | ||
| return NewMicroTime(time.Now()) | ||
| } |
There was a problem hiding this comment.
@tylerslaton Possibly. What did you have in mind? a generic implementation?
There was a problem hiding this comment.
I was thinking of just porting these over for discoverability purposes.
njhale
force-pushed
the
events/filter-time
branch
from
257806b to
0935a22
Compare
thedadams
approved these changes
Jul 13, 2023
njhale
force-pushed
the
events/filter-time
branch
from
4f17997 to
0b65a61
Compare
|
Pushed some changes to address @g-linville's feedback (see #1920 (comment)). Requesting re-reviews |
tylerslaton
approved these changes
Jul 14, 2023
thedadams
approved these changes
Jul 14, 2023
g-linville
approved these changes
Jul 14, 2023
Add two new options to the `acorn events` subcommand: - `--since` will determine the start of the time span; excludes events observed before this point when provided - `--until` will determine the end of the time span; excludes events observed after this point when provided Each option accepts a single argument; arguments can be Unix timestamps, date formatted timestamps, or Go duration strings(relative to system time). Signed-off-by: Nick Hale <[email protected]>
Co-authored-by: Tyler Slaton <[email protected]> Signed-off-by: Nick Hale <[email protected]>
Add support for unix timestamp strings when parsing since and until. Signed-off-by: Nick Hale <[email protected]>
Co-authored-by: Grant Linville <[email protected]> Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
events/filter-time
branch
from
87c50fc to
139d7c8
Compare
|
Just pushed a simple rebase. Conflict was small and contained. Tests are passing, so I don't think this requires another round of review. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new options to the
acorn eventssubcommand:--sincewill determine the start of the time span; excludes eventsobserved before this point when provided
--untilwill determine the end of the time span; excludes eventsobserved after this point when provided
Each option accepts a single argument; arguments can be Unix timestamps,
date formatted timestamps, or Go duration strings(relative to system time).
Addresses #1805