Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Remove -A from almost all commands (#1897) #1907

Merged
merged 12 commits into from
Jul 14, 2023

Conversation

g-linville
Copy link
Contributor

@g-linville g-linville commented Jul 10, 2023

for #1897

-A is now only supported for acorn ps. Also, ps is the main name for that command now, instead of apps (which is still a valid alias).

Additionally, the behavior of -A will now only include other projects in the same Acorn "instance" (one installation of Runtime, or one instance of Manager).

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@g-linville g-linville changed the title Draft: Remove -A from almost all commands Draft: Remove -A from almost all commands (#1897) Jul 10, 2023
@g-linville g-linville changed the title Draft: Remove -A from almost all commands (#1897) Remove -A from almost all commands (#1897) Jul 10, 2023
@g-linville g-linville marked this pull request as ready for review July 10, 2023 21:25
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
Signed-off-by: Grant Linville <[email protected]>
@g-linville g-linville force-pushed the remove-all-projects-option branch from ae78fb7 to 0cdd2ef Compare July 13, 2023 20:03
Copy link
Contributor

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions, but nothing blocking.
LGTM

Signed-off-by: Grant Linville <[email protected]>
@g-linville g-linville requested a review from thedadams July 14, 2023 15:33
Signed-off-by: Grant Linville <[email protected]>
@g-linville g-linville merged commit 833dcb4 into acorn-io:main Jul 14, 2023
@g-linville g-linville deleted the remove-all-projects-option branch July 14, 2023 18:38
cloudnautique pushed a commit to cloudnautique/runtime that referenced this pull request Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants