This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Ensure that delete jobs run when projects are deleted (#1893) #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedadams
commented
Jul 6, 2023
pkg/controller/defaults/testdata/memory/all-set-overwrite/expected.golden
Outdated
Show resolved
Hide resolved
thedadams
force-pushed
the
add-project-instances
branch
2 times, most recently
from
fc30dfe to
ba0246e
Compare
thedadams
commented
Jul 6, 2023
| @@ -10,9 +10,6 @@ spec: | |||
| "": sample-compute-class | |||
| status: | |||
| observedGeneration: 1 | |||
| defaults: | |||
There was a problem hiding this comment.
This was a duplicate entry.
thedadams
force-pushed
the
add-project-instances
branch
7 times, most recently
from
736086e to
0e92484
Compare
thedadams
requested review from
StrongMonkey,
iwilltry42,
g-linville and
tylerslaton
g-linville
reviewed
Jul 6, 2023
pkg/controller/defaults/testdata/region/default/expected.golden
Outdated
Show resolved
Hide resolved
Comment on lines
+38
to
+41
| type projectCreater struct { | ||
| creater strategy.Creater | ||
| client kclient.Client | ||
| } |
There was a problem hiding this comment.
nit: I know the underlying typo/misspelling comes from mink, but I think this is worth changing anyway
Suggested change
| type projectCreater struct { | |
| creater strategy.Creater | |
| client kclient.Client | |
| } | |
| type projectCreator struct { | |
| creator strategy.Creater | |
| client kclient.Client | |
| } |
(Would need to modify other parts of this file too.)
g-linville
approved these changes
Jul 6, 2023
thedadams
force-pushed
the
add-project-instances
branch
4 times, most recently
from
560eb3f to
e33a983
Compare
thedadams
changed the title
StrongMonkey
reviewed
Jul 7, 2023
pkg/uninstall/uninstall.go
Outdated
| if err := c.Get(ctx, kclient.ObjectKey{Namespace: "kube-system", Name: "acorn-controller"}, controllerLease); !apierror.IsNotFound(err) && err != nil { | ||
| return nil, err | ||
| } | ||
| if err == nil { |
There was a problem hiding this comment.
the err here is not the err in the if statement above?
There was a problem hiding this comment.
You're right. Will fix.
StrongMonkey
reviewed
Jul 7, 2023
| @@ -80,6 +82,14 @@ func baseResources(ctx context.Context, c kclient.Client) (resources []kclient.O | |||
| } | |||
| } | |||
|
|
|||
| controllerLease := &coordinationv1.Lease{} | |||
| if err := c.Get(ctx, kclient.ObjectKey{Namespace: "kube-system", Name: "acorn-controller"}, controllerLease); !apierror.IsNotFound(err) && err != nil { | |||
There was a problem hiding this comment.
Does the lease live in acorn-system or kube-system?
There was a problem hiding this comment.
It lives in the kube-system namespace.
thedadams
force-pushed
the
add-project-instances
branch
from
e33a983 to
0c2ecd4
Compare
StrongMonkey
approved these changes
Jul 7, 2023
thedadams
force-pushed
the
add-project-instances
branch
from
0c2ecd4 to
20d54dc
Compare
There are a few situations where we need a buffer between a project being deleted and the corresponding namespace being deleted. One such scenario is ensuring that delete jobs run when a project is deleted. This change adds a project instance, which is this buffer. Using the project instance, we can ensure that all apps are successfully cleaned up before the namespace is deleted. This should also give the user the ability to use the ignore-cleanup functionality when deleting a project. Changes are also made to the integration tests to use project instances instead of namespaces. Signed-off-by: Donnie Adams <[email protected]>
thedadams
force-pushed
the
add-project-instances
branch
from
20d54dc to
0b9b373
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few situations where we need a buffer between a project being deleted and the corresponding namespace being deleted. One such scenario is ensuring that delete jobs run when a project is deleted.
This change adds a project instance, which is this buffer. Using the project instance, we can ensure that all apps are successfully cleaned up before the namespace is deleted. This should also give the user the ability to use the ignore-cleanup functionality when deleting a project.
Checklist
This is a title (#1216). Here's an exampleRequires: acorn-io/baaah#90
Issue: #1893