Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Always set AutoUpgrade if it is implied (#1459) #1881

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

tylerslaton
Copy link
Contributor

for #1459

Prior to this commit, AutoUpgrade would not get set for Apps that had implied AutoUpgrade behavior. For example, if an App came through with AutoUpgradeInterval set or a pattern set for its Image then AutoUpgrade would be false despite it actually being enabled.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@tylerslaton tylerslaton force-pushed the always-set-autoupgrade branch 3 times, most recently from 332eedb to 05d14b1 Compare July 2, 2023 21:56
@tylerslaton tylerslaton marked this pull request as ready for review July 2, 2023 23:50
@tylerslaton tylerslaton force-pushed the always-set-autoupgrade branch 2 times, most recently from ee4b417 to 2bb55fd Compare July 7, 2023 14:15
@tylerslaton tylerslaton force-pushed the always-set-autoupgrade branch from 2bb55fd to a98179d Compare July 9, 2023 18:22
@tylerslaton tylerslaton requested a review from thedadams July 9, 2023 18:22
@tylerslaton tylerslaton force-pushed the always-set-autoupgrade branch 3 times, most recently from 35e9000 to 3319497 Compare July 10, 2023 02:10
@tylerslaton tylerslaton force-pushed the always-set-autoupgrade branch from 3319497 to fb0fdd2 Compare July 10, 2023 02:39
@tylerslaton tylerslaton merged commit dfe417b into acorn-io:main Jul 10, 2023
@tylerslaton tylerslaton deleted the always-set-autoupgrade branch July 10, 2023 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants