Rename event severity warn to error and rm critical

pkg/apis/internal.acorn.io/v1/event.go

@@ -97,15 +97,10 @@ func (t *MicroTime) UnmarshalJSON(b []byte) error {
 
 const (
 	// EventSeverityInfo indicates an event describes a system operating "as expected".
-	// It is the lowest severity level.
 	EventSeverityInfo EventSeverity = "info"
 
-	// EventSeverityWarn indicates an event describes a recoverable error.
-	EventSeverityWarn EventSeverity = "warn"
-
-	// EventSeverityCritical indicates an event describes an unrecoverable error.
-	// It is the highest severity level.
-	EventSeverityCritical EventSeverity = "critical"
+	// EventSeverityError indicates an event describes an error.
+	EventSeverityError EventSeverity = "warn"
 )
 
 // EventSeverity indicates the severity of an event.

pkg/controller/appdefinition/pullappimage.go

@@ -226,7 +226,7 @@ func recordPullEvent(ctx context.Context, recorder event.Recorder, observed meta
 	if err != nil {
 		// It's a failure, overwrite with failure event values
 		e.Type = AppImagePullFailureEventType
-		e.Severity = v1.EventSeverityWarn
+		e.Severity = v1.EventSeverityError
 		e.Description = fmt.Sprintf("Failed to pull %s", target.Name)
 		details.Err = err.Error()
 	}

pkg/controller/appdefinition/pullappimage_test.go

@@ -171,7 +171,7 @@ func TestPullAppImageEvents(t *testing.T) {
 		&apiv1.Event{
 			Type:        AppImagePullFailureEventType,
 			Actor:       "acorn-system",
-			Severity:    v1.EventSeverityWarn,
+			Severity:    v1.EventSeverityError,
 			Description: "Failed to pull acorn.io/img:1",
 			Source:      v1.EventSource{Kind: "app", Name: "foo"},
 			Observed:    now,