This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Autoupgrade fixes #1845
Merged
Autoupgrade fixes #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-linville
requested review from
thedadams,
njhale,
StrongMonkey,
iwilltry42 and
tylerslaton
g-linville
force-pushed
the
autoupgrade-fixes
branch
from
508788a to
59514aa
Compare
Signed-off-by: Grant Linville <[email protected]>
g-linville
force-pushed
the
autoupgrade-fixes
branch
from
59514aa to
1738db8
Compare
|
Squashed everything down to one commit to make it easier to rebase. |
StrongMonkey
reviewed
Jul 3, 2023
| var ( | ||
| _, autoUpgradeOn = autoupgrade.Mode(appInstance.Spec) | ||
| resolved string | ||
| err error | ||
| isLocal bool | ||
| ) | ||
| if !appInstance.Status.AvailableAppImageRemote { | ||
| // Only attempt to resolve locally if auto-upgrade is not on, or if auto-upgrade is on but we know the image is not remote. |
There was a problem hiding this comment.
The comment makes code easier to understand 👍
StrongMonkey
approved these changes
Jul 3, 2023
thedadams
approved these changes
Jul 6, 2023
| t.Fatal("error while getting rest config:", err) | ||
| } | ||
| kclient := helper.MustReturn(kclient.Default) | ||
| project := helper.TempProject(t, kclient) |
cloudnautique
pushed a commit
to cloudnautique/runtime
that referenced
this pull request
Sep 28, 2023
…acorn-io#1845) Signed-off-by: Grant Linville <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1823
This further prevents Docker Hub from being assumed for auto-upgrade apps. From the previous PR, some of the validation was done client-side, leading to the ability to deploy an auto-upgrade app with Docker Hub as the default registry if done by applying a YAML manifest directly to the cluster.
This PR also ensures that auto-upgrade apps will prefer remote images over local images, including on the initial deployment. (Prior to this there was a problem where an auto-upgrade app would prioritize local images at first, and then the daemon would prioritize remote images. This fixes that.)
Checklist
This is a title (#1216). Here's an example