This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Fix build cache issues #1807
Merged
Fix build cache issues #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuildthecloud
force-pushed
the
table-out
branch
from
7a4027e to
68a248a
Compare
Do not attempt to get job output if the helper sidecar is not known to be running. This will reduce many spurious errors when trying to get output on of a job when it's not ready or running. Also don't ignore errors for job shutdown. Signed-off-by: Darren Shepherd <[email protected]>
Signed-off-by: Darren Shepherd <[email protected]>
Signed-off-by: Darren Shepherd <[email protected]>
Previously --arg @file.yaml was supported, but no there was no way to
pass data on the command line. Now the format --arg @{"json":"content"}
is also supported
Signed-off-by: Darren Shepherd <[email protected]>
Currently a reference to a secret will implicitly create an opaque secret or volume. We retain that behavior but not for any secret/volume is a non-local reference which means it contains a period. Signed-off-by: Darren Shepherd <[email protected]>
ibuildthecloud
force-pushed
the
table-out
branch
from
68a248a to
8a007f2
Compare
ibuildthecloud
changed the title
Signed-off-by: Darren Shepherd <[email protected]>
Signed-off-by: Darren Shepherd <[email protected]>
Each build was always using the same context scratch space, causing each build to invalidate the cache from the previous. Now a consistent cache key is generated for subsequent builds Signed-off-by: Darren Shepherd <[email protected]>
If an image is dymanically added at runtime, not part of the build, it must be defined in the acornfile images section. A bug existed where a service acorn with it's build referenced from the images section could not be determined at runtime. Signed-off-by: Darren Shepherd <[email protected]>
If an AppInstance CR for a service acorn was yet to be created because of a pending secret or other resource it was possible that a circular reference could be created and cause a stack overflow. Circular references are now checked and for this situation where it could happen temporarily we look for that specific situation. Signed-off-by: Darren Shepherd <[email protected]>
Signed-off-by: Darren Shepherd <[email protected]>
Signed-off-by: Darren Shepherd <[email protected]>
ibuildthecloud
force-pushed
the
table-out
branch
from
8a007f2 to
777dccf
Compare
Signed-off-by: Darren Shepherd <[email protected]>
Signed-off-by: Darren Shepherd <[email protected]>
ibuildthecloud
force-pushed
the
table-out
branch
from
777dccf to
adbb4ca
Compare
Signed-off-by: Darren Shepherd <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.