Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Always return event details #1906

Closed
njhale opened this issue Jul 10, 2023 · 2 comments
Closed

Always return event details #1906

njhale opened this issue Jul 10, 2023 · 2 comments
Assignees
@njhale
Labels
area/events kind/enhancement New feature or request
Milestone
v0.8.0

Comments

@njhale
Copy link
Member

njhale commented Jul 10, 2023 •
edited
Loading

Description

Requests to list and watch events should never strip event details.

Background

The details field of a runtime event allows for context specific information to be added. For example, VCS info is included for AppImagePull events.

By default, the runtime API elides the field on list and watch unless otherwise opted-in by the request. The idea was to reduce the overhead when working with lots events containing potentially large details.

Motivation

This was likely a premature optimization since, in practice, the details field has been used to store small payloads, similar in size to their respective objects.
@njhale njhale self-assigned this Jul 10, 2023
@njhale njhale added this to the v0.8.0 milestone Jul 10, 2023
@cjellick cjellick mentioned this issue Jul 10, 2023
Closed
@njhale njhale mentioned this issue Jul 10, 2023
Merged
njhale added a commit that referenced this issue Jul 10, 2023
@njhale
Merge pull request #1908 from njhale/events/show-details
bf57373 
 Always return event details (#1906)
@njhale njhale mentioned this issue Jul 11, 2023
Merged
@njhale
Copy link
Member Author

njhale commented Jul 11, 2023 •
edited
Loading

Opened #1913 to address something I missed in #1908 (removes the --details flag)

@njhale njhale added the kind/enhancement New feature or request label Jul 11, 2023
njhale added a commit that referenced this issue Jul 11, 2023
@njhale
Merge pull request #1913 from njhale/events/drop-details-flag
ea9b439 
Drop details flag from acorn events subcommand (#1906)
@sangee2004
Copy link
Contributor

Tested with acorn version - v0.8.0-alpha7-98-gbb130866+bb130866

  1. acorn events -o json always returns details info.
  2. There is no support for "--details" flag anymore.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@njhale njhale

Labels
area/events kind/enhancement New feature or request
Projects
None yet
Milestone
v0.8.0
Development

No branches or pull requests
2 participants
@njhale @sangee2004