better errors part 1 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tag: gets Error() so it can fulfill Go's error interface - compiler: constructs a Tag with multiple tags that contain info about the error - instructions/blacklight.go: have to pass in a filename and receive err Next Steps ---------- - Replace filename with an "environment" object that contains filename and other metadata for better errors - Store *.bl source file info in file_env object and use it in the compiler or anywhere else it is needed - Source map for keeping track of bytecodes vs file offsets - Decompile bytecodes upon error
acook
force-pushed
the
internal_errors
branch
from
a3c9aac to
9d5ee70
Compare
|
Code duplication between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the end-all-be-all of errors, more work will be done in the future, but figuring out where in a file the error occured is indeterminable from Go
panicdumps, so leads to a lot of guesswork.Errors should say which...
..the error occured on.
Including which Go file/line the error was generated on is useful too. The token number and raw byte offset in the
.blsource is good for debugging how tokens are parsed, but might be removed later. Most of the info in this paragraph already exists.