-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DNS API support for Nexcess, Thermo.io, and Futurehosting #1812
Conversation
please check this guide https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide |
@Neilpang Thanks. I have read through the guide. Is there something specific I am missing from it? |
@Neilpang is there anything additional that is needed on this PR? |
Bumping this back up. Anything needed on my end @Neilpang? |
Merge Conflicts Resolved. |
Conflicts Resolved. (Again). |
https://github.com/Neilpang/acme.sh/wiki/DNS-API-Dev-Guide please make sure you can handle all the domains:
And support v2 wildcard: |
All issues have been corrected. Also confirmed that it works with all example, including v2 wildcard. |
Sorry, I just noticed that you said these 3 apis are identical. export XXX_AccessToken=xxxxxxx
export XXX_Endpoint="https://my.futurehosting.com/"
acme.sh --issue -d example.com --dns dns_xxx.sh We can save what do you think ? |
@Neilpang Thats actually a good idea. I'll work out the details and update the PR |
Do not merge yet. Still need to do some final testing. |
@Neilpang This has been tested and should be good to go. |
please close this PR, and make a new one. Thanks. |
Done. #2082 |
This adds DNS support for Nexcess, Futurehosting, and Thermo.io
All 3 use the same API backend (different endpoints), so the code is mostly identical other than the names of things.