-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an example using Git for dependency resolution #5
Conversation
Note that code in google/cargo-raze#22 is broken in that it finishes without generating BUILD files in the git-vendored libraries, google/cargo-raze#28 is currently broken with some panicking |
Thanks for the additional example! The repo structure is a bit weird, and as-is this example is going to get clobbered next time ./internal/update-master.sh is run. What that script does is copy the example directories from ./internal/sources into ./bazel, then run Can you move the example (sans vendored crates +generated BUILDs) into ./internal/sources as well so that update-master.sh can see it? |
Ah, also can you update the new sanity_check.sh script to match #4 (putting both of the builds on the same line joined with &&)? |
Waiting for Travis, but I think this is what you were going for? |
The error from Travis, of which I have no idea what's going on:
|
You're missing an explicit dependency on For some reason you can sometimes depend on crates without explicitly depending on them, but only in unstable, and only for certain crates. See rust-lang/rust#27812 for details |
Which is strange, because it's definitely included in the Cargo.toml. |
I linked the handwritten example BUILD file for the example (not a generated build file). You missed the |
This LGTM. I feel like we're going to want to probably reduce the number of whole examples back to two-ish (one per genmode) to reduce the number of redundant compilations of crates and speed up CI, but its not a big deal for now. Not yet sure the best way to do that and still have the features "accessible". Thanks again! |
Should help in testing google/cargo-raze#22 and google/cargo-raze#28.
Currently broken, as BUILD files aren't generated in Git vendored dependencies.