-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX-575 upgrade to 6.0 alpha, refactor stories for sidepanel #440
Conversation
|
Hm, in my version? |
@@ -10,15 +10,13 @@ const propTypes = { | |||
* Will accept the click event on outside of the sidepanel when losing focus | |||
* @boolean | |||
*/ | |||
background: PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this technically constitutes a breaking change to SidePanel
. I'm okay with that, it will be very low impact, but please indicate that in the PR description, tag the PR with that label, and add a note to the CHANGELOG
.
You can't toggle any expandable selection closed, if the active story is contained below. And since a "component" section auto selects the first story, you're seeing that behaviour. If you go selecte the Heading/Showcase story, then you can close the Guard, but won't be able to close the Heading. This make some sense, if you collapse the section with the active page... then you can't see where the active page is anymore and you can get lost. |
Can you add |
Hey, I think that with these new options, we don't need the confusing "Canvas / Docs" tabs at all! In fact, it seems they can be turned off, while still maintaining the rest of that "canvas toolbar" by adding this to the story parameters:
Reference: storybookjs/storybook#9095 |
180a83a
to
e4d0cbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose 🚀
Notes ✏️
Updates 📦
Storybook 📕
http://storybooks.highbond-s3.com/paprika/UX-575-sidepanel-stories