feat: require php 8.1 & update phpunit to v10 #127
Conversation
| "symfony/http-client": "^5.3|^6.0", | ||
| "symfony/yaml": "^3.0|^4.0|^5.0|^6.0", | ||
| "php-vcr/php-vcr": "^1.4.5", | ||
| "php-vcr/php-vcr": "dev-master#c0aeeba0f3804fcfdb9cd6b390b0cb3be250c070 as 1.9.0", |
There was a problem hiding this comment.
php 8.4 support is not tagged 😭
| @@ -66,26 +66,24 @@ public function recordsSuccessAndClose() | |||
| /** | |||
| * @test | |||
| */ | |||
| public function notifyTripped() | |||
| public function tripsOnce() | |||
There was a problem hiding this comment.
I am not entirely certain what this test was asserting, my assumption here is that the EVENT_TRIPPED is passed only once?
There was a problem hiding this comment.
You are right! My intention was to test that Ganesha::EVENT_TRIPPED is triggered, and that it happens only once.
README.md
Outdated
There was a problem hiding this comment.
I did not update the versions table as I am not sure how do you want to proceed, @ackintosh. I don't think that this change requires a major bump, everyone one 8.0 can still use previous 3.x versions.
| @@ -13,11 +13,11 @@ | |||
| "repositories": [ | |||
| { | |||
| "type": "git", | |||
| "url": "https://github.com/kornrunner/phpunit-testlistener-vcr" | |||
| "url": "https://github.com/marmichalski/phpunit-testlistener-vcr" | |||
There was a problem hiding this comment.
PHPUnit 10 event system support: php-vcr/phpunit-testlistener-vcr#45
|
Thank you for your contribution, @marmichalski ! I think that dropping support for a specific PHP version is a breaking change, so I will include this PR in the next major version (4.0). v4.0 will be released soon after the current master is released as v3.2. |
Hey, in that case we could consider bumping the PHP requirement even higher (8.3?) while also updating the code with new features (ctor property promotion, readonly properties/classes, etc) :) |
|
v4.0 has been released! 🙏 https://github.com/ackintosh/ganesha/releases/tag/4.0.0 |
Supersedes #120.
I can split the PR into separate one dropping PHP 8.0 and then this just upgrading phpunit, but I guess it is fine in one, too 🙈
Reasoning being that PHP 8.0 is already EOL for some time.