Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intervalToHalfOpen not work for Redis storage #29

Closed
wenbinye opened this issue Dec 9, 2018 · 2 comments
Closed

intervalToHalfOpen not work for Redis storage #29

wenbinye opened this issue Dec 9, 2018 · 2 comments

Comments

@wenbinye
Copy link

wenbinye commented Dec 9, 2018

Redis storage adapter does not implements saveLastFailureTime,and loadLastFailureTime suppose the key is failureKey, instead of lastFailureKey, so always got null value.

Change Ackintosh\Ganesha\Storage lastFailureKey as following works:

    /**
     * @param  string $service
     * @return string
     */
    private function lastFailureKey($service)
    {
        return $this->supportRollingTimeWindow() 
            ? $this->failureKey($service) 
            : $this->prefix($service) . self::KEY_SUFFIX_LAST_FAILURE_TIME;
    }
@wenbinye wenbinye changed the title Redis intervalToHalfOpen not work intervalToHalfOpen not work for Redis storage Dec 9, 2018
@ackintosh
Copy link
Owner

@wenbinye Thanks for reporting the issue! I'll have a look this weekend. 😉

@ackintosh
Copy link
Owner

@wenbinye I've fixed the issue on #30. which is released as v0.2.2. Thank you again. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants