Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis Adapter does not initialise status #27

Closed
Sertion opened this issue Oct 9, 2018 · 3 comments · Fixed by #28
Closed

Redis Adapter does not initialise status #27

Sertion opened this issue Oct 9, 2018 · 3 comments · Fixed by #28

Comments

@Sertion
Copy link

Sertion commented Oct 9, 2018

The Redis adapter will never be able to loadStatus successfully as it will always exit with Failed to load status. The status is therefor never set. In the same situation in the Memcached adapter it will initialise the status with Ganesha::STATUS_CALMED_DOWN.

The issues can clearly be seen by subscribing to the Ganesha instance.
@ackintosh
Copy link
Owner

@Sertion Thanks for reporting the issue! I'll investigate the cause of the issue on this weekend.

ackintosh added a commit that referenced this issue Oct 31, 2018
@ackintosh
Add a test case which reproduces the issue #27
692c339
@ackintosh ackintosh mentioned this issue Oct 31, 2018
Merged
@ackintosh
Copy link
Owner

@Sertion I've fixed the issue and released the fix as 0.2.1. 🚀

https://github.com/ackintosh/ganesha/releases/tag/0.2.1

Please give it a try when you have time. Again, thanks for your feedback!!

@Sertion
Copy link
Author

Sertion commented Oct 31, 2018

Great news! Thank you for looking into the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Redis Adapter doesn't return initial status properly ackintosh/ganesha
2 participants
@Sertion @ackintosh