Upload coverage results on PHP8

ackintosh · Aug 27, 2022 · b38a161 · b38a161
1 parent dc7c31e
commit b38a161
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -64,10 +64,7 @@ jobs:
 
       # https://github.com/php-coveralls/php-coveralls#github-actions
       - name: Upload coverage results to Coveralls
-        # NOTE: For now we would run this step only on php7.4 due to the error on php8.
-        # https://github.com/ackintosh/ganesha/runs/4375377952?check_suite_focus=true
-        # > PHP Fatal error:  Declaration of PhpCoveralls\Bundle\CoverallsBundle\Console\Application::getDefinition() must be compatible with ...
-        if: ${{ matrix.php-version == '7.4' }}
+        if: ${{ matrix.php-version == '8.0' }}
         env:
           COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |