Upgrade rails to v7 #270
Merged
Upgrade rails to v7 #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regexp now requires that after the comma there is "zero or more" spaces followed by either a single or double quote, _then_ zero or more of our specific characters that could be used in a version constraint. This fix is needed because Rails 7 now doesn't require `bootsnap`, meaning we'd end up creating an invalid Gemfile by inserting `gem "bootsnap", require, require: false`.
emre-simtay
commented
Jan 21, 2022
emre-simtay
commented
Jan 21, 2022
G-Rath
requested review from
dp4rk,
eoinkelly,
alr888,
Breccan,
hopkincame,
JacobBriggsAckama,
joshmcarthur,
mischa-s,
mokomokoy and
robramsaynz
G-Rath
reviewed
Jan 21, 2022
G-Rath
reviewed
Jan 21, 2022
emre-simtay
force-pushed
the
upgrade-rails-to-v7
branch
from
8c34442 to
702c6c8
Compare
G-Rath
reviewed
Jan 21, 2022
|
❤️ your work on this @emre-simtay |
Closed
eoinkelly
reviewed
Jan 21, 2022
emre-simtay
force-pushed
the
upgrade-rails-to-v7
branch
from
702c6c8 to
8e0e8c7
Compare
|
I'm seeing test failures locally which aren't happening in CI. I have created PR #271 to explore this. |
eoinkelly
reviewed
Jan 26, 2022
* Update node & ruby versions in CI to latest stable * Use ruby 3.0 because brakeman does not support 3.1 yet * Fix hash syntax for ruby 3.0 * Stop failing code coverage based on almost empty default Rails files
Closed
Good stuff.
G-Rath
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268