Improve logging to screen and run.dat #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the logging to screen and to the
run.dat
file thatacis_thermal_check
does at the beginning of its run. Specifically:chandra_models
version we used to screen. If we do use this one, reportchandra_models
version asNone
and report the full path to the file.output
directory that we used when printing out the command line options (currently it prints out the__repr__
of the directory which is aPosixPath
).For this sample command:
In the current version of
acis_thermal_check
, we see this:with this PR, we see this:
If we supply a model specification file like so:
In the current version of
acis_thermal_check
, we see this:with this PR, we see this:
Interface impacts
Changes the visual appearance of the logging to screen and the
run.dat
file, but both of these are currently only human-read.Testing
Unit tests
Functional tests
Checked to make sure that different combinations of specifying
model-spec
or not worked correctly.