-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Only Darwin for PNLF #75
Conversation
add _sta method return for win acpi
putting method _sta with darwin, on windows there is no more error. |
I still don't get why you use OpenCore to boot Windows. That's just dumb. Use the boot menu and separate disks... |
and a bootloader that has dual boot, why should I use boot windows from bios? if adding the method _STA resolves? |
Contional OS patching has been demonstrated to be unreliable, that's why OpenCore does not have policies about when it's necessary to apply the settings described in the config.plist or not. Just does. So why are you applying random _STA here and there if booting from the UEFI boot menu is a much cleaner approach to keep OSes and their relative firmwares/drivers separate? |
with your statement, you consider useless the methods is already present in ssdt ec, pmc etc etc |
Makes sense to me, we did not have that on our devices. Could you include the same change for CFL table nearby? |
do you want to apply change to ssdt pnlf and ssdt pnlf cfl? in both? |
Correct. |
FIX _STA METHOD RETURN
ok, also applied to ssdt pnlf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix identation
do I need to do anything else? |
The change looks good to me. Will merge when we get CI fixed. |
ok thank you,, but I have ice lake laptop, and the igpu doesn't work well, I can't patch hdmi, and problems with backlight and maximum bkl value, depends on weg, after 3 minutes that start, the backlight turns on, depends on weg. |
#76 try this. |
thank you, later I fill in and try 😘 |
thank you so much, work well backlight right away, I don't have to wait 3 minutes, great pr your 💪 |
add _sta method return for win acpi