Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Only Darwin for PNLF #75

Merged
merged 4 commits into from
Dec 3, 2020
Merged

Docs: Only Darwin for PNLF #75

merged 4 commits into from
Dec 3, 2020

Conversation

Lorys89
Copy link
Contributor

@Lorys89 Lorys89 commented Nov 25, 2020

add _sta method return for win acpi

add _sta method return for win acpi
@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 25, 2020

IMG_20201126_003434

@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 25, 2020

putting method _sta with darwin, on windows there is no more error.

@1alessandro1
Copy link

I still don't get why you use OpenCore to boot Windows. That's just dumb.

Use the boot menu and separate disks...

@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 26, 2020

Continuo a non capire perché usi OpenCore per avviare Windows. È solo stupido.

Usa il menu di avvio e dischi separati ...

and a bootloader that has dual boot, why should I use boot windows from bios? if adding the method _STA resolves?
it makes no sense what you say.

@1alessandro1
Copy link

Contional OS patching has been demonstrated to be unreliable, that's why OpenCore does not have policies about when it's necessary to apply the settings described in the config.plist or not.

Just does.

So why are you applying random _STA here and there if booting from the UEFI boot menu is a much cleaner approach to keep OSes and their relative firmwares/drivers separate?

@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 26, 2020

with your statement, you consider useless the methods is already present in ssdt ec, pmc etc etc
I do not share it, but I accept your thoughts. I await the opinion of the devs.

@vit9696
Copy link
Collaborator

vit9696 commented Nov 26, 2020

Makes sense to me, we did not have that on our devices. Could you include the same change for CFL table nearby?

@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 26, 2020

Makes sense to me, we did not have that on our devices. Could you include the same change for CFL table nearby?

do you want to apply change to ssdt pnlf and ssdt pnlf cfl? in both?

@vit9696
Copy link
Collaborator

vit9696 commented Nov 26, 2020

Correct.

FIX _STA METHOD RETURN
@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 26, 2020

Correct.

ok, also applied to ssdt pnlf

Copy link
Contributor Author

@Lorys89 Lorys89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix identation

@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 26, 2020

Correct.

do I need to do anything else?

@vit9696
Copy link
Collaborator

vit9696 commented Nov 26, 2020

The change looks good to me. Will merge when we get CI fixed.

@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 26, 2020

Il cambiamento mi sembra buono. Si fonderanno quando avremo riparato CI.

ok thank you,, but I have ice lake laptop, and the igpu doesn't work well, I can't patch hdmi, and problems with backlight and maximum bkl value, depends on weg, after 3 minutes that start, the backlight turns on, depends on weg.

@Andrey1970AppleLife Andrey1970AppleLife changed the title fix ssdt pnlf cfl Docs: Only Darwin for PNLF Nov 26, 2020
@idalin
Copy link

idalin commented Nov 27, 2020

Il cambiamento mi sembra buono. Si fonderanno quando avremo riparato CI.

ok thank you,, but I have ice lake laptop, and the igpu doesn't work well, I can't patch hdmi, and problems with backlight and maximum bkl value, depends on weg, after 3 minutes that start, the backlight turns on, depends on weg.

#76 try this.

@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 27, 2020

Il cambiamento mi sembra buono. Si fonderanno quando avremo riparato CI.

ok thank you,, but I have ice lake laptop, and the igpu doesn't work well, I can't patch hdmi, and problems with backlight and maximum bkl value, depends on weg, after 3 minutes that start, the backlight turns on, depends on weg.

#76 try this.

thank you, later I fill in and try 😘

@Lorys89
Copy link
Contributor Author

Lorys89 commented Nov 27, 2020

Il cambiamento mi sembra buono. Si fonderanno quando avremo riparato CI.

ok thank you,, but I have ice lake laptop, and the igpu doesn't work well, I can't patch hdmi, and problems with backlight and maximum bkl value, depends on weg, after 3 minutes that start, the backlight turns on, depends on weg.

#76 try this.

thank you so much, work well backlight right away, I don't have to wait 3 minutes, great pr your 💪

@vit9696 vit9696 merged commit fb2b72e into acidanthera:master Dec 3, 2020
0xFireWolf pushed a commit to 0xFireWolf/WhateverGreen that referenced this pull request Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants