perf: use Buffer.allocUnsafe where available #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `Buffer.allocUnsafe` is available, and we know we are about to fill the returned vales, use it in preference to `new Uint8Array` as it is much faster.
Codecov Report
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 98.15% 97.45% -0.70%
==========================================
Files 7 8 +1
Lines 217 236 +19
Branches 44 47 +3
==========================================
+ Hits 213 230 +17
- Misses 4 6 +2
Continue to review full report at Codecov.
|
hugomrdias
approved these changes
Jul 25, 2022
wemeetagain
reviewed
Aug 1, 2022
| * @param {number} length | ||
| * @returns {Uint8Array} | ||
| */ | ||
| export function allocUnsafe (length) { |
There was a problem hiding this comment.
maybe this could be exported too? Used in protons?
| * @returns {Uint8Array} | ||
| */ | ||
| export function allocUnsafe (length) { | ||
| if (globalThis.Buffer != null) { |
There was a problem hiding this comment.
I think the protons version looks like if (globalThis?.Buffer?.allocUnsafe != null) {
There was a problem hiding this comment.
That's probably overkill - globalThis exists everywhere supported so just globalThis.Buffer?.allocUnsafe would do.
|
Superseded by #34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Buffer.allocUnsafeis available, and we know we are about to fill the returned vales, use it in preference tonew Uint8Arrayas it is much faster.