fix: make pbStream function polymorphic #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What we want to say is that the type returned from `unwrap` will be the original duplex passed in, but it's source will have changed to return `Uint8ArrayList`s. We can still pass duplexes that source `Uint8Array`s though, so make the exported function polymorphic.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
## [3.0.1](v3.0.0...v3.0.1) (2023-03-01) ### Bug Fixes * make pbStream function polymorphic ([#40](#40)) ([ccb2065](ccb2065))
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we want to say is that the type returned from
unwrapwill be the original duplex passed in, but it's source will have changed to returnUint8ArrayLists. We can still pass duplexes that sourceUint8Arrays though, so make the exported function polymorphic.