Added queue properties to bindQueueConsumer and bindPrivateQueueConsumer #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Version 0.2.1 cannot bind to persistent/durable queues.
The implementation of
bindQueueConsumer
(in the_ExchangeImpl
class) invokes channel.queue only with the queueName, so the durable parameter always defaults to false.dart_amqp/lib/src/client/impl/exchange_impl.dart
Line 88 in 0231485
If the queue did not exist, it was created as non-durable.
If it did exist, an exception would be thrown because the existing queue has durable=true and this line is trying to get a queue with durable=false.
Solution
This pull request adds
durable
(and all the other parameters the queue method can have) to the parameters of thebindQueueConsumer
method. That way, the invoker can indicate they want to bind to a durable queue. For example,For consistency, it does the same thing to
bindPrivateQueueConsumer
.The change is backward compatible, since the added parameters are all named parameters that are either nullable or have default values.