Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that calls with a noWait=true flag complete returned Futures #64

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

achilleasa
Copy link
Owner

When an application ivokes any of the library methods with the noWait
flag set, the broker will not reply back with a message to confirm that the
request (e.g. declare a queue, exchange etc.) was successful. As a
result the returned Future values where never completed thus causing the
callers to hang.

When using the noWait flag, the broker will report errors asynchronously
via the channel or connection instance.

When an application ivokes any of the library methods with the noWait
flag set, the broker will not reply back with a message to confirm that the
request (e.g. declare a queue, exchange etc.) was successful. As a
result the returned Future values where never completed thus causing the
callers to hang.

When using the noWait flag, the broker will report errors asynchronously
via the channel or connection instance.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 93.107% when pulling ac86799 on fix-incorrect-handling-of-nowait-flag into 41410bf on master.

@achilleasa achilleasa merged commit cb18a05 into master Oct 1, 2021
@achilleasa achilleasa deleted the fix-incorrect-handling-of-nowait-flag branch October 1, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants