Support publish confirmations #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleasa
force-pushed
the
support-confirm
branch
from
98cef45 to
f9ff6cb
Compare
Repository owner
deleted a comment from
coveralls
Sep 29, 2021
The confirm.select/select-ok messages are described in https://www.rabbitmq.com/resources/specs/amqp0-9-1.extended.xml The Basic.Ack/Nack messages are typically used by clients. However, when publish confirmations are enabled, the broker will also send these to the client. To this end, this commit defines the class for Basic.Nack and adds the "fromStream" factory method so we can unmarshal these messages when sent by the broker.
This mechanism is exposed via two new channel-level methods. The confirmPublishedMessages method enables it for a particular channel (further invocations of the method are treated as no-ops). The publishNotifier method allows applications to subscribe to a stream for publish notifications. Each notification contains the original message and message properties as well as a flag which indicates whether the broker handled (e.g. persisted to stable storage) or lost the message.
achilleasa
force-pushed
the
support-confirm
branch
from
f9ff6cb to
0f62a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for publish confirmations as described here.
The publish confirmation mechanism is exposed via two new channel-level methods.
confirmPublishedMessagesmethod enables it for a particular channel (further invocations of the method are treated as no-ops).publishNotifiermethod allows applications to subscribe to a stream for publish notifications. Each notification contains the original message and message properties as well as a flag which indicates whether the broker handled (e.g. persisted to stable storage) or lost the message.Note that receiving an ACK for a message does not guarantee that it has been processed by one or more consumers. For example, when publishing to a queue with no consumers, the broker (tested with rabbitmq 3.9.7) will still ACK the message.
The PR also includes an example (in example/confirm) of using this new feature.
Fixes #60