Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code #23

Merged
merged 5 commits into from
Sep 18, 2019
Merged

Update code #23

merged 5 commits into from
Sep 18, 2019

Conversation

a14n
Copy link
Contributor

@a14n a14n commented Mar 22, 2019

Basically this PR :

  • enable some lints (those from pedantic-1.5.0 and some other you will find in analysis_options.yaml).
  • use async/await to improve code lisibility

I made several commits to make it more understandable. If you think this is too coarse grained, let me know and I will try to split this PR.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 86.81% when pulling ba4c310 on a14n:update-code into ac925e6 on achilleasa:master.

@achilleasa achilleasa merged commit a69a421 into achilleasa:master Sep 18, 2019
@a14n a14n deleted the update-code branch September 18, 2019 07:09
@a14n
Copy link
Contributor Author

a14n commented Sep 18, 2019

Awesome! I'd completely forgot this PR 🤣

BTW This should increase the score of the package on pub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a14n @coveralls @achilleasa