Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter/Dart 2 compatibility changes #15

Merged
merged 2 commits into from
Jun 14, 2018
Merged

Flutter/Dart 2 compatibility changes #15

merged 2 commits into from
Jun 14, 2018

Conversation

rmathias86
Copy link

Flutter/Dart 2 compatibility changes

  • Updating logging version due Flutter dependency requiring version 11+
  • Some dart 2 support, type enforcement: Passing type argument. At least seems like working well with flutter beta/master channel.

@codecov-io
Copy link

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   93.79%   93.79%           
=======================================
  Files          55       55           
  Lines        2853     2853           
=======================================
  Hits         2676     2676           
  Misses        177      177
Impacted Files Coverage Δ
lib/src/client/impl/channel_impl.dart 96.69% <100%> (ø) ⬆️
lib/src/client/impl/exchange_impl.dart 100% <100%> (ø) ⬆️
lib/src/client/impl/consumer_impl.dart 100% <100%> (ø) ⬆️
lib/src/client/impl/queue_impl.dart 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b173336...2c92e49. Read the comment docs.

@achilleasa achilleasa merged commit 8845bba into achilleasa:master Jun 14, 2018
@rmathias86 rmathias86 mentioned this pull request Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants