Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with dart 2 #14

Merged
merged 2 commits into from
Jun 14, 2018

Conversation

achilleasa
Copy link
Owner

@achilleasa achilleasa commented Jun 12, 2018

This PR fixes some issues reported by the dartanalyzer binary that ships with the dart2 SDK. These changes should allow this package to be used with dart2.

According to the discussion in #13, for flutter2 compatibility dartanalyzer must be ran with --no-implicit-casts which reports a couple more issues that can be fixed with a separate PR.

@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #14 into master will decrease coverage by 1.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #14     +/-   ##
=========================================
- Coverage   94.89%   93.79%   -1.1%     
=========================================
  Files          55       55             
  Lines        2625     2853    +228     
=========================================
+ Hits         2491     2676    +185     
- Misses        134      177     +43
Impacted Files Coverage Δ
test/lib/encode_decode_test.dart 99.03% <ø> (ø) ⬆️
lib/src/enums/error_type.dart 100% <100%> (ø) ⬆️
test/lib/mocks/mocks.dart 47.88% <100%> (-0.39%) ⬇️
lib/src/client/impl/channel_impl.dart 96.69% <100%> (-0.15%) ⬇️
.../src/protocol/frame/impl/heartbeat_frame_impl.dart 16.66% <0%> (-83.34%) ⬇️
lib/src/protocol/messages/bindings/tx.dart 83.33% <0%> (-16.67%) ⬇️
lib/src/protocol/messages/bindings/exchange.dart 90% <0%> (-10%) ⬇️
lib/src/protocol/messages/bindings/queue.dart 91.07% <0%> (-8.93%) ⬇️
lib/src/protocol/messages/bindings/basic.dart 91.54% <0%> (-8.46%) ⬇️
lib/src/protocol/messages/bindings/connection.dart 93.65% <0%> (-6.35%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2889b21...e3ff5d5. Read the comment docs.

@achilleasa achilleasa mentioned this pull request Jun 13, 2018
@achilleasa achilleasa merged commit b173336 into master Jun 14, 2018
@achilleasa achilleasa deleted the improve-compatibility-with-dart-2 branch June 14, 2018 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants