Raise HeartbeatFailedException after missing maxMissedHeartbeats (new tuning param) consecutive heartbeats #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a suggestion from #106 (comment). The client-side heartbeat implementation is modified via the introduction of a new tuning parameter called `maxMissedHeartbeats` (default: 3). If heartbeats are enabled and the client sends `maxMissedHeartbeats` consecutive heartbeat messages at the interval negotiated with the broker without receiving any message (heartbeat or regular traffic) back, the client assumes that the server is not available and will raise a HeartbeatFailedException.
achilleasa
force-pushed
the
track-missed-heartbeats
branch
from
fd85301 to
9e52ca9
Compare
|
This implementation looks reasonable and it's similar to what we've been running successfully for about a month now. I'd like to propose an alternative implementation that's a bit simpler which I parked in this draft pr #114 |
|
TBH, I consider this implementation simpler as the timer will get correctly reset in all scenarios (re-connects e.t.c.). The in-flight tracking PR makes sense but needs more work to make sure that the counter gets correctly reset. In the meantime I will land this CL so it does not bitrot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a suggestion from #106 (comment).
The client-side heartbeat implementation is modified via the
introduction of a new tuning parameter called
maxMissedHeartbeats(default: 3).
If heartbeats are enabled and the client sends
maxMissedHeartbeatsconsecutive heartbeat messages at the interval negotiated with the
broker without receiving any message (heartbeat or regular traffic)
back, the client assumes that the server is not available and will raise
a HeartbeatFailedException.
Fixes #106