Vehicle Damage - Add API to prevent AI from dismounting from immobile vehicles

[johnb432]

When merged this pull request will:

• Title.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[veteran29]

Why not simply use engine command?

https://community.bistudio.com/wiki/isAllowedCrewInImmobile

[johnb432]

Why not simply use engine command?

https://community.bistudio.com/wiki/isAllowedCrewInImmobile

I'm trying to find a good reason why not to use isAllowedCrewInImmobile, but I honestly can't. It would make it compatible with mods using the vanilla command, which would be my exact use case.

For context:

ACE sets it when a vehicle is spawned, see

ACE3/addons/vehicle_damage/functions/fnc_addEventHandler.sqf

Line 99 in 9d16875

_vehicle allowCrewInImmobile true;

ACE unsets it here

ACE3/addons/vehicle_damage/functions/fnc_abandon.sqf

Line 23 in 9d16875

_vehicle allowCrewInImmobile false;

Since you have already reviewed - @jonpas and @BrettMayson, do you have any objection to vet's proposal?

[BrettMayson]

No objections from me

[johnb432]

but I honestly can't

@veteran29 I was too tired to see that using isAllowedCrewInImmobile won't work, unless we change more stuff (which I don't think it possible).

As said previously,

ACE3/addons/vehicle_damage/functions/fnc_addEventHandler.sqf

Line 99 in 9d16875

_vehicle allowCrewInImmobile true;

sets it to true. How are we supposed to distinguish us vs. other sources setting that? Using status effects would imo not solve the problem.

I was going to add a if (isAllowedCrewInImmobile _vehicle) exitWith {}; check inside FUNC(abandon), but that won't work since that is always going to be true - and if it isn't, they would bail. I'm fairly certain that allowCrewInImmobile is set to true so that we can handle bailout ourselves.

isAllowedCrewInImmobile can't work, status effect is overkill for this, can revisit before release if problematic