-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragging - Add possiblity to rotate a carried object #7640
Conversation
Example: https://streamable.com/qfaxkv |
<Chinesesimp>提高/下降</Chinesesimp> | ||
<Turkish>Yukarı/Aşağı</Turkish> | ||
<Key ID="STR_ACE_Dragging_RaiseLowerRotate"> | ||
<English>Raise/Lower | (Ctrl + Scroll) Rotate</English> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<English>Raise/Lower | (Ctrl + Scroll) Rotate</English> | |
<English>Raise/Lower | (Ctrl + Scroll Wheel) Rotate</English> |
<Turkish>Yukarı/Aşağı</Turkish> | ||
<Key ID="STR_ACE_Dragging_RaiseLowerRotate"> | ||
<English>Raise/Lower | (Ctrl + Scroll) Rotate</English> | ||
<German>Heben/Senken | (Strg + Scrollen) Drehen</German> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<German>Heben/Senken | (Strg + Scrollen) Drehen</German> | |
<German>Heben/Senken | (Strg + Scrollrad) Drehen</German> |
Scroll is not a key. Scroll Lock is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then change it there as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Can be done in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, do not change. Scroll is scroll wheel rolling, there is also a Middle Mouse Button as key which is also used in Advanced Throwing and using "Scroll Wheel" could mean either of the two.
I used the same as in adv. throwing. Might be for a future improvement where we change this to use a small key cap icon Ctrl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested working in mp
@@ -63,7 +63,7 @@ _unit setVariable [QGVAR(ReleaseActionID), [ | |||
if (_target isKindOf "CAManBase") then { | |||
[localize LSTRING(Drop), "", ""] call EFUNC(interaction,showMouseHint); | |||
} else { | |||
[localize LSTRING(Drop), "", localize LSTRING(LowerRaise)] call EFUNC(interaction,showMouseHint); | |||
[localize LSTRING(Drop), "", localize LSTRING(RaiseLowerRotate)] call EFUNC(interaction,showMouseHint); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[localize LSTRING(Drop), "", localize LSTRING(RaiseLowerRotate)] call EFUNC(interaction,showMouseHint); | |
[localize LSTRING(Drop), "", LLSTRING(LowerRaise), [["control", LLSTRING(rotate)]]] call EFUNC(interaction,showMouseHint); |
The advantage of doing this now is we don't have to drop our existing translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hideous, though
When merged this pull request will: