Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sandbag to editor #3102

Merged
merged 2 commits into from
Feb 4, 2016
Merged

Add Sandbag to editor #3102

merged 2 commits into from
Feb 4, 2016

Conversation

cthulhusec
Copy link
Contributor

As per #2633

Make Sandbag available for placement in editor (Under Objects)
Also renames ACE_SandbagObject to ACE_Sandbag

@jonpas
Copy link
Member

jonpas commented Jan 1, 2016

That breaks backwards compatibility, I wouldn't change the classname.

@cthulhusec
Copy link
Contributor Author

@jonpas I doubt that is much of an issue but @commy2 asked for it.

@jokoho48
Copy link
Member

jokoho48 commented Jan 1, 2016

i think you better only change the visibilty or you add a backward compatible

@@ -6,7 +6,7 @@ class CfgPatches {
weapons[] = {"ACE_Sandbag", "ACE_Sandbag_empty"};
requiredVersion = REQUIRED_VERSION;
requiredAddons[] = {"ace_interaction"};
author[] = {"Rocko", "Ruthberg"};
author[] = {"Rocko", "Ruthberg", "Buddytex"};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think thats a little bit to much :S

@cthulhusec cthulhusec closed this Jan 1, 2016
@cthulhusec cthulhusec reopened this Jan 1, 2016
@cthulhusec
Copy link
Contributor Author

@jokoho48 There only the visibility change, I'm not entirely sure how to ensure backwards compatibility with a class in ArmA.

side = -1;
model = PATHTOF(data\ace_sandbag_build.p3d);
displayName = CSTRING(sandbag_displayName);
vehicleClass = "Objects";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs instead of spaces.

@commy2
Copy link
Contributor

commy2 commented Jan 1, 2016

nvm

side = -1;
model = PATHTOF(data\ace_sandbag_build.p3d);
displayName = CSTRING(sandbag_displayName);
vehicleClass = "Objects";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be "ACE_Logistics_Items".

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jan 4, 2016
@PabstMirror PabstMirror added this to the 3.5.0 milestone Jan 7, 2016
thojkooi added a commit that referenced this pull request Feb 4, 2016
@thojkooi thojkooi merged commit 893040b into acemod:master Feb 4, 2016
@novmikvis
Copy link

Am I missing something? img img2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants