-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read settings from paramsArray (params in description.ext) #2826
Conversation
for now just limited to SCALAR/BOOL
Nice idea! |
I have this in my mission template. Essentially one must call this at postInit. Here the function where I set the different parameters (for the moment only Basic medical, advanced medical and advanced ballistics on/of without requiring any of the modules/missionconfig.cpp files. Everything could be dynamically set at mission start. Edit: lines 139 and 140 for the medical stuff and 473 for advanced ballistics. |
Shouldn't it happen after modules? Good idea though 👍 |
@SilentSpike no, the settings here are forced. Anything coming after it will be ignored. |
It looks as though they're only forced if said so in the config, but since they're parameters they should probably take precedence over modules |
Ah, I was looking at the true on the In that case; they are not forced. But I see no issue with them being executed before modules. |
Well, if somene places a module to change a bunch of settings, but wants one of the settings handled by the module to be handled by parameter instead then the module will override it |
Modules will overwrite and force all settings in the module (unless they are already forced)
|
Yeah, I'm thinking this should just force by default 👍 I can't think of a scenario where you want a module to overwrite a parameter (it nullifies the parameter). |
Read settings from paramsArray (params in description.ext)
Is parameters > modules still working? I seem to remember it did work before the last update, but now the modules settings are taken instead of the defaults in description.ext. Or is it just me? |
What do you mean with that? All previous options from the ACE settings framework still work. |
If I set up description.ext with parameters, for example ace_medical_level with default 1 and ace_medical_medicSetting with default 1 and then place the medical module in editor with both values set to 2, then the mission will take the values from module and not from description.ext. And I seem to remember, that a few days/weeks earlier the description.ext default values had highest priority. |
Ok, nevermind, I see, we have to use ACE_setting = 1 now. I'm sorry, thanks. |
Just an idea, not sure if we need
Allows you to make settings changeable by mission params, so one mission can be played with different settings
for now just limited to SCALAR/BOOL
e.g.