Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lead calculation for vehicle FCS #2779

Merged
merged 2 commits into from
Oct 21, 2015
Merged

Fix lead calculation for vehicle FCS #2779

merged 2 commits into from
Oct 21, 2015

Conversation

VKing6
Copy link
Member

@VKing6 VKing6 commented Oct 21, 2015

Fix lead calculation aspect of #2126

@VKing6 VKing6 added target/next-milestone? kind/bug-fix Release Notes: **FIXED:** labels Oct 21, 2015
@jokoho48
Copy link
Member

there is the issue with regex :D

@commy2
Copy link
Contributor

commy2 commented Oct 21, 2015

Why next milestone? Should be merged right now.

@VKing6
Copy link
Member Author

VKing6 commented Oct 21, 2015

Sure.

KoffeinFlummi added a commit that referenced this pull request Oct 21, 2015
Fix lead calculation for vehicle FCS
@KoffeinFlummi KoffeinFlummi merged commit 5d7a8af into master Oct 21, 2015
@KoffeinFlummi KoffeinFlummi deleted the fixFCSLead branch October 21, 2015 20:33
@jokoho48 jokoho48 added this to the 3.4.0 milestone Oct 21, 2015
@kymckay
Copy link
Member

kymckay commented Oct 21, 2015

there is the issue with regex :D

Nah, this is where regex could have prevented these edge cases 😉

@jokoho48
Copy link
Member

yeah i am not so known how regex work but i think we now have 3 or 4 times the time issue :D

@VKing6
Copy link
Member Author

VKing6 commented Oct 21, 2015

https://xkcd.com/208/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants