Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectator updates #2760

Merged
merged 12 commits into from
Nov 21, 2015
Merged

Spectator updates #2760

merged 12 commits into from
Nov 21, 2015

Conversation

kymckay
Copy link
Member

@kymckay kymckay commented Oct 17, 2015

Includes:

Todo:

kymckay added 7 commits October 4, 2015 13:52
@kymckay
Add API parameter to allow for unforced spectator
0beaa40 
Adds an optional boolean paremeter to the setSpectator function for forcing the interface. It is forced by default, so if `false` is passed as the value the spectator will be able to close the interface with the escape button.
@kymckay
End spectator interface when the mission ends
b1dda86 
Fixes #2592 (in theory) by forcing spectator closed on mission end
@kymckay
Decrease default spectator camera speed
f0f822b
@kymckay
Improve spectator seagull handling
52d703c 
Previously they were only hidden, but this didn't account for the annoying audio they play so now they're entirely staged like a spectator unit would be.
@kymckay
Fix spectator 3D icons not rendering
c1dc8a6 
Fixes #2676 as per voiperr's suggestion (working with camera can be really strange, I swear this worked before)
@kymckay
Update spectator function headers
4079ca3
@kymckay
Add vision mode support to spectator external cam
780e0aa 
Since external view is actually another camera, vision modes should also apply to it too.
@kymckay kymckay added kind/enhancement Release Notes: **IMPROVED:** status/WIP kind/bug-fix Release Notes: **FIXED:** labels Oct 17, 2015
@kymckay kymckay self-assigned this Oct 17, 2015
@kymckay kymckay added this to the 3.4.0 milestone Oct 17, 2015
@kymckay
Reduce overhead of spectator map icons
b6dd7b9 
Fixes #2514 by only rendering individual unit icons when zoomed in and only rendering the units currently within the screen bounds.

Behaves as expected, but whether or not it has a significant performance increase under scaled up testing conditions remains to be seen.
@kymckay kymckay mentioned this pull request Oct 20, 2015
Closed
@kymckay
Remove ear ringing upon spectator entry
cf368f2 
Volume updating was disabled, however any existing ringing would persist. Setting the volume to 0 should make the hearing PFH stop playing sound.
@kymckay
Remove depreciated spectator hotkey
23e110d
@kymckay
Fix spectator unit list key press handling
0567d1c 
By setting maxHistroyDelay really high, the unit list shouldn't be messed with via key press very often.
@kymckay
Localise spectator hotkeys in help window
f8e293d
@kymckay
Copy link
Member Author

kymckay commented Nov 21, 2015

Merging the current improvements now. Will continue working on further updates on the same branch.

kymckay added a commit that referenced this pull request Nov 21, 2015
@kymckay
Merge pull request #2760 from acemod/spectatorUpdates
f07f06c 
Spectator updates
@kymckay kymckay merged commit f07f06c into master Nov 21, 2015
@kymckay kymckay deleted the spectatorUpdates branch November 21, 2015 15:02
@kymckay kymckay restored the spectatorUpdates branch November 21, 2015 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kymckay kymckay

Labels
kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@kymckay